Refactoring some code, merge st-probe and fixup #318 serial print #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 15, 2016 22:20
…linux. Add some better sanity checking when using libusb_open and cleanup accordingly. Fixes hang (debian 8, amd64, libusb 1.0.19): libusb: warning [add_to_flying_list] failed to arm first timerfd (errno 9) libusb: warning [libusb_close] internal signalling write failed, closing anyway
* Fixup #318 serial print in stlink probe with trailing zeros * Refactor stlink-usb.h with some doxygen-style comments * Refactor some pieces of stlink_open_usb
…not compared in search
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stlink_open_usbAs there is no real codestyle and very inconsistent the pieces which needs some refactoring I used linux codestyle. Probably a good idea would be to have linux checkpatch linter in the repository.